Fix potential NPE in ApiCallAttemptTimeoutTrackingStage #6332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age when exception is thrown before the tracker can be set in the context
zoewangg
approved these changes
Aug 15, 2025
| "type": "bugfix", | ||
| "category": "AWS SDK for Java v2", | ||
| "contributor": "", | ||
| "description": "Fix a potential NullPointerException in ApiCallAttemptTimeoutTrackingStage where the RequestExecutionContext might not have a timeout tracker configured" |
There was a problem hiding this comment.
nit: suggesting something more customer facing: Fix a potential NullPointerException that may be thrown when API call timeout is configured.
There is always a risk of this happening, I believe the root cause is when the timeout task is rejected by the |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix potential NullPointerException in ApiCallAttemptTimeoutTrackingStage when exception is thrown before the tracker can be set in the context
Motivation and Context
Customer reported NPE because the call to
context.apiCallAttemptTimeoutTracker()returns null. There is some code that could throw an exception before thetimeoutTrackeris set on the context, particularly if theScheduledExecutorServicerejects the scheduled task for some reason.Modifications
Added null check
Testing
ran unit tests